-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat/deepgramTopicDetection): Added Deepgram Topic Detection using Kotlin #98
(feat/deepgramTopicDetection): Added Deepgram Topic Detection using Kotlin #98
Conversation
7cf6f2c
to
73a701b
Compare
Thank you so much for the PR 🤩. We're adding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! 🤯 We left some comments during the review, please check them out.
return res.json( | ||
data = mapOf( | ||
"success" to true, | ||
"deepgramData" to response.toString() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please return this as a Map rather than a string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still being returned as a String
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, It is returning response as a map now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not being returned as a map yet. it's still a string.
ebfe583
to
731023b
Compare
Hello @stnguyen90, Please review it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JayantGoel001 some comments haven't been addressed.
return res.json( | ||
data = mapOf( | ||
"success" to true, | ||
"deepgramData" to response.toString() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still being returned as a String
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments.
return mapOf( | ||
"success" to true, | ||
"deepgramData" to response | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't return mapOf
like this:
$ docker run -e INTERNAL_RUNTIME_ENTRYPOINT=Index.kt --rm --interactive --tty --volume $PWD:/usr/code openruntimes/kotlin:v2-1.6 sh /usr/local/src/build.sh
Downloading https://services.gradle.org/distributions/gradle-7.4.1-bin.zip
...........10%...........20%...........30%...........40%...........50%...........60%...........70%...........80%...........90%...........100%
Welcome to Gradle 7.4.1!
Here are the highlights of this release:
- Aggregated test and JaCoCo reports
- Marking additional test source directories as tests in IntelliJ
- Support for Adoptium JDKs in Java toolchains
For more details see https://docs.gradle.org/7.4.1/release-notes.html
Starting a Gradle Daemon (subsequent builds will be faster)
> Task :processResources
> Task :compileKotlin FAILED
e: /usr/local/src/src/main/kotlin/io/openruntimes/kotlin/Wrapper.kt: (60, 16): Type mismatch: inferred type is Map<String, {Comparable<{Boolean & StringBuilder}> & java.io.Serializable}> but RuntimeResponse was expected
e: /usr/local/src/src/main/kotlin/io/openruntimes/kotlin/Wrapper.kt: (65, 16): Type mismatch: inferred type is Map<String, {Comparable<{Boolean & String}> & java.io.Serializable}?> but RuntimeResponse was expected
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':compileKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
> Compilation error. See log for more details
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 30s
2 actionable tasks: 2 executed
How are you testing this code?
return res.json( | ||
data = mapOf( | ||
"success" to true, | ||
"deepgramData" to response.toString() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not being returned as a map yet. it's still a string.
Fixes: appwrite/appwrite#4461
@tessamero please review it.