(feat/deepgramTopicDetection): Added Deepgram Topic Detection using Kotlin #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7cf6f2c
to
73a701b
Compare
|
Thank you so much for the PR 🤩. We're adding the |
stnguyen90
requested changes
Nov 9, 2022
| return res.json( | ||
| data = mapOf( | ||
| "success" to true, | ||
| "deepgramData" to response.toString() |
There was a problem hiding this comment.
Would you please return this as a Map rather than a string?
There was a problem hiding this comment.
This is still being returned as a String
There was a problem hiding this comment.
Yes, It is returning response as a map now.
There was a problem hiding this comment.
It is not being returned as a map yet. it's still a string.
ebfe583
to
731023b
Compare
|
Hello @stnguyen90, Please review it again. |
stnguyen90
requested changes
Nov 10, 2022
| return res.json( | ||
| data = mapOf( | ||
| "success" to true, | ||
| "deepgramData" to response.toString() |
There was a problem hiding this comment.
This is still being returned as a String
stnguyen90
requested changes
Nov 14, 2022
Comment on lines
+57
to
+60
| return mapOf( | ||
| "success" to true, | ||
| "deepgramData" to response | ||
| ) |
There was a problem hiding this comment.
You can't return mapOf like this:
$ docker run -e INTERNAL_RUNTIME_ENTRYPOINT=Index.kt --rm --interactive --tty --volume $PWD:/usr/code openruntimes/kotlin:v2-1.6 sh /usr/local/src/build.sh
Downloading https://services.gradle.org/distributions/gradle-7.4.1-bin.zip
...........10%...........20%...........30%...........40%...........50%...........60%...........70%...........80%...........90%...........100%
Welcome to Gradle 7.4.1!
Here are the highlights of this release:
- Aggregated test and JaCoCo reports
- Marking additional test source directories as tests in IntelliJ
- Support for Adoptium JDKs in Java toolchains
For more details see https://docs.gradle.org/7.4.1/release-notes.html
Starting a Gradle Daemon (subsequent builds will be faster)
> Task :processResources
> Task :compileKotlin FAILED
e: /usr/local/src/src/main/kotlin/io/openruntimes/kotlin/Wrapper.kt: (60, 16): Type mismatch: inferred type is Map<String, {Comparable<{Boolean & StringBuilder}> & java.io.Serializable}> but RuntimeResponse was expected
e: /usr/local/src/src/main/kotlin/io/openruntimes/kotlin/Wrapper.kt: (65, 16): Type mismatch: inferred type is Map<String, {Comparable<{Boolean & String}> & java.io.Serializable}?> but RuntimeResponse was expected
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':compileKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
> Compilation error. See log for more details
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 30s
2 actionable tasks: 2 executedHow are you testing this code?
| return res.json( | ||
| data = mapOf( | ||
| "success" to true, | ||
| "deepgramData" to response.toString() |
There was a problem hiding this comment.
It is not being returned as a map yet. it's still a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: appwrite/appwrite#4461
@tessamero please review it.