Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added generate map function #65

Merged
merged 10 commits into from
Jan 23, 2023
Merged

Added generate map function #65

merged 10 commits into from
Jan 23, 2023

Conversation

partik03
Copy link
Contributor

@partik03 partik03 commented Oct 8, 2022 •
edited by stnguyen90
Loading

Closes: appwrite/appwrite#4133

Screenshot from 2022-10-09 22-23-09
Without Longitude
Screenshot from 2022-10-09 22-23-24
Without Latitude
Screenshot from 2022-10-09 22-27-52
Invalid Longitude or Latitude
Screenshot from 2022-10-09 22-27-33

@partik03
Copy link
Contributor Author

@Shivansh-yadav13 can you merge this pull request,now??

@Shivansh-yadav13
Copy link

@partik03 I'm just a contributor 😄 , I was just referencing your PR.

MrKrishnaAgarwal
MrKrishnaAgarwal approved these changes Oct 17, 2022
View reviewed changes
Copy link

@MrKrishnaAgarwal MrKrishnaAgarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Meldiron
Copy link
Contributor

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

@stnguyen90 stnguyen90 self-requested a review November 1, 2022 15:53
stnguyen90
stnguyen90 requested changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! 🤯 We left some comments during the review, please check them out.

python/generate-map/main.py Outdated Show resolved Hide resolved
python/generate-map/main.py Outdated Show resolved Hide resolved
python/generate-map/main.py Outdated Show resolved Hide resolved
python/generate-map/main.py Show resolved Hide resolved
python/generate-map/main.py Outdated Show resolved Hide resolved
python/generate-map/main.py Outdated Show resolved Hide resolved
python/generate-map/main.py Outdated Show resolved Hide resolved
python/generate-map/main.py Outdated Show resolved Hide resolved
python/generate-map/main.py Outdated Show resolved Hide resolved
python/generate-map/main.py Outdated Show resolved Hide resolved
@adityaoberai
Copy link
Member

Hey @partik03
Have you had a chance to review the changes recommended earlier on the PR?

@stnguyen90 stnguyen90 self-requested a review November 7, 2022 19:07
stnguyen90
stnguyen90 previously requested changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments and re-request a review when ready.

python/generate-map/main.py Outdated Show resolved Hide resolved
python/generate-map/main.py Outdated Show resolved Hide resolved
python/generate-map/README.md Outdated Show resolved Hide resolved
python/generate-map/README.md Outdated Show resolved Hide resolved
python/generate-map/README.md Outdated Show resolved Hide resolved
@Meldiron
Copy link
Contributor

Thanks for the amazing PR 😇 I have added small changes to fix base64 encoding and updated documentation.
Merging the PR now 🥳

@Meldiron Meldiron dismissed stnguyen90’s stale review January 23, 2023 07:38

All addressed. Dismissing to merge

@Meldiron Meldiron merged commit fd18ce0 into open-runtimes:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shivansh-yadav13 Shivansh-yadav13 Shivansh-yadav13 left review comments

@Meldiron Meldiron Meldiron approved these changes

@MrKrishnaAgarwal MrKrishnaAgarwal MrKrishnaAgarwal approved these changes

@stnguyen90 stnguyen90 stnguyen90 left review comments

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

⚡ Write a generateMap() Function using Python
6 participants
@partik03 @Shivansh-yadav13 @Meldiron @adityaoberai @stnguyen90 @MrKrishnaAgarwal