Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generateShortUrl Function using Deno #57

Merged
merged 6 commits into from
Jan 22, 2023
Merged

generateShortUrl Function using Deno #57

merged 6 commits into from
Jan 22, 2023

Conversation

eigengravy
Copy link
Contributor

Closes appwrite/appwrite#4185

Proof of working
image

@Meldiron
Copy link
Contributor

Meldiron commented Oct 7, 2022

@eigengravy , thanks for the PR! 🤯 Please give us some time to review it.

@stnguyen90 stnguyen90 self-requested a review October 27, 2022 23:04
stnguyen90
stnguyen90 requested changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! 🤯 We left some comments during the review, please check them out.

deno/generate_short_url/README.md Outdated Show resolved Hide resolved
deno/generate_short_url/src/mod.ts Outdated Show resolved Hide resolved
deno/generate_short_url/README.md Outdated Show resolved Hide resolved
@stnguyen90 stnguyen90 self-requested a review October 28, 2022 14:14
stnguyen90
stnguyen90 requested changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more changes please.

deno/generate_short_url/src/mod.ts Outdated Show resolved Hide resolved
deno/generate_short_url/src/mod.ts Outdated Show resolved Hide resolved
deno/generate_short_url/src/mod.ts Outdated Show resolved Hide resolved
@stnguyen90 stnguyen90 marked this pull request as draft October 28, 2022 20:55
@eigengravy
Copy link
Contributor Author

@stnguyen90 have made the required changes

@eigengravy eigengravy marked this pull request as ready for review October 30, 2022 11:30
@Meldiron
Copy link
Contributor

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

@stnguyen90 stnguyen90 self-requested a review November 17, 2022 19:48
stnguyen90
stnguyen90 previously requested changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there's a problem with bitly

deno/generate_short_url/src/mod.ts Outdated Show resolved Hide resolved
@Meldiron Meldiron dismissed stnguyen90’s stale review January 22, 2023 09:21

All comments resolved. Dismissing to allow merging

@Meldiron
Copy link
Contributor

Thanks for the amazing PR 😇 I have added small changes to fix documentation.
Merging the PR now 🥳

@Meldiron Meldiron merged commit 4972545 into open-runtimes:main Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meldiron Meldiron Meldiron approved these changes

@stnguyen90 stnguyen90 stnguyen90 left review comments

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

⚡ Write a generateShortUrl() Function using Deno
3 participants
@eigengravy @Meldiron @stnguyen90