Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Translate text implementation using C# #55

Closed

Conversation

gagandeepp
Copy link

@gagandeepp gagandeepp commented Oct 6, 2022

@gagandeepp gagandeepp changed the title Translate text implementation Added Translate text implementation using C# Oct 6, 2022
@Meldiron
Copy link
Contributor

@gagandeepp , thanks for the PR! 🤯 Please give us some time to review it.

Copy link
Member

@adityaoberai adityaoberai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gagandeepp please review the changes mentioned and add a Readme for the function along with screenshots showing that the function works

<Nullable>enable</Nullable>
</PropertyGroup>

<ItemGroup>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are using Newtonsoft.Json, please remove the item group here

public string? To { get; set; }
public string? Text { get; set; }
}
class Program
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function structure is incorrect and should be as shown in the .NET Example here in our docs

@PineappleIOnic
Copy link
Contributor

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

@Meldiron
Copy link
Contributor

Hey there 👋
We are temporarily closing your PR as there has been no activity on it. Feel free to re-open it when you're ready to start working on it again 😇

@Meldiron Meldiron closed this Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚡ Write a translateText() Function using .NET
4 participants