Write a generateWebsiteScreenshot() Function using Deno #4108 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@wess @TorstenDittmann @abnegate @Meldiron Please provide feedback for this pull request |
stnguyen90
requested changes
Oct 24, 2022
There was a problem hiding this comment.
@FarhanAliRaza Great PR! 🤯 We left some comments during the review, please check them out.
Co-authored-by: Steven <[email protected]>
Co-authored-by: Steven <[email protected]>
Co-authored-by: Steven <[email protected]>
Co-authored-by: Steven <[email protected]>
stnguyen90
requested changes
Oct 25, 2022
|
Thank you so much for the PR 🤩. We're adding the |
stnguyen90
previously requested changes
Oct 31, 2022
4 tasks
|
@FarhanAliRaza please address the comments |
|
ok |
Meldiron
approved these changes
Jan 23, 2023
Meldiron
dismissed
stnguyen90’s stale review
All resolved. Dismissing to merge
|
Thanks for the amazing PR 😇 I have added small changes to fix error handling and improve readme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was assigned to me. I tested it on my local app write instance and it works. I attached a screenshot of successful response by the function.