Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added deno code for invoice generator #46

Closed
wants to merge 3 commits into from

Conversation

camperjett
Copy link
Contributor

@camperjett camperjett commented Oct 5, 2022

Signed-off-by: Jaideep Sharma [email protected]

Closes: appwrite/appwrite#4089

PS: This PR is submitted for Hacktoberfest'22

Screenshots:

Screenshot from 2022-10-05 17-09-44
Screenshot from 2022-10-05 18-25-43
Screenshot from 2022-10-05 18-26-08

@PineappleIOnic
Copy link
Contributor

Hey There 👋
Thanks for the PR! Could you please attach an image to this issue of the function being successfully executed?

@camperjett
Copy link
Contributor Author

@PineappleIOnic Check it out!

@camperjett
Copy link
Contributor Author

PTAL 👀 @PineappleIOnic

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! 🤯 We left some comments during the review, please check them out.

Comment on lines +27 to +36
docker run -e INTERNAL_RUNTIME_ENTRYPOINT=src/mod.ts --rm --interactive --tty --volume $PWD:/usr/code openruntimes/deno:1.14 sh /usr/local/src/build.sh
```
As a result, a `code.tar.gz` file will be generated.

3. Start the Open Runtime:
```
docker run -p 3000:3000 -e INTERNAL_RUNTIME_ENTRYPOINT=src/mod.ts -e INTERNAL_RUNTIME_KEY=secret-key -e INTERNAL_RUNTIME_ENTRYPOINT=mod.ts --rm --interactive --tty --volume $PWD/code.tar.gz:/tmp/code.tar.gz:ro openruntimes/deno:1.14 sh /usr/local/src/start.sh
```

Your function is now listening on port `3000`, and you can execute it by sending `POST` request with appropriate authorization headers. To learn more about runtime, you can visit Deno runtime [README](https://github.com/open-runtimes/open-runtimes/tree/main/runtimes/deno-1.14).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to use the newest image: openruntimes/deno:v2-1.24

Thumbs.db

.vscode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to add this. we may want to add .vscode in the future.

@Meldiron
Copy link
Contributor

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

@christyjacob4
Copy link
Contributor

@camperjett please address the comments

@Meldiron
Copy link
Contributor

Hey there 👋
We are temporarily closing your PR as there has been no activity on it. Feel free to re-open it when you're ready to start working on it again 😇

@Meldiron Meldiron closed this Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚡ Write a generateInvoice() Function using Deno
5 participants