Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡ Write a generateShortUrl() Function using PHP #36

Merged
merged 7 commits into from
Jan 22, 2023
Merged

⚡ Write a generateShortUrl() Function using PHP #36

merged 7 commits into from
Jan 22, 2023

Conversation

TheSylwio
Copy link
Contributor

@TheSylwio TheSylwio commented Oct 4, 2022 •
edited
Loading

@TheSylwio TheSylwio changed the title Generate short URL ⚡ Write a generateShortUrl() Function using PHP Oct 5, 2022
@TheSylwio TheSylwio mentioned this pull request Oct 11, 2022
Closed
4 tasks
@Meldiron
Copy link
Contributor

@TheSylwio , thanks for the PR! 🤯 Please give us some time to review it.

Meldiron
Meldiron requested changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing PR! 🎉 Left a few tiny comments, nothing major. Once they are addressed, I can give approving review 😇

php/generate-short-url/README.md Show resolved Hide resolved
php/generate-short-url/README.md Show resolved Hide resolved
php/generate-short-url/composer.json Outdated Show resolved Hide resolved
php/generate-short-url/index.php Outdated Show resolved Hide resolved
php/generate-short-url/index.php Outdated Show resolved Hide resolved
@TheSylwio
Copy link
Contributor Author

@Meldiron Thank you for the review. I have applied changes now 😄

@TheSylwio
Copy link
Contributor Author

@Meldiron reminder 🙂👋

@ChandanChainani
Copy link

ChandanChainani commented Oct 24, 2022 •
edited
Loading

@TheSylwio Please can you add Closes #4187 to the description so the PR gets linked to the issue and after merging it closes the issue and it will also help others to know that there is a PR raised for the issue

@TheSylwio
Copy link
Contributor Author

Updated

@Meldiron
Copy link
Contributor

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

@Meldiron
Copy link
Contributor

Thanks for the amazing PR 😇 I have added small changes to fix env variables and documentation.
Merging the PR now 🥳

@Meldiron Meldiron merged commit 7d60268 into open-runtimes:main Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meldiron Meldiron Meldiron approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

⚡ Write a generateShortUrl() Function using PHP
3 participants
@TheSylwio @Meldiron @ChandanChainani