Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sendHTTPRequest Function using Deno #30

Merged
merged 5 commits into from
Jan 20, 2023
Merged

sendHTTPRequest Function using Deno #30

merged 5 commits into from
Jan 20, 2023

Conversation

eigengravy
Copy link
Contributor

@eigengravy eigengravy commented Oct 3, 2022 •
edited
Loading

Closes appwrite/appwrite#4174

Proof of working
image

@eigengravy eigengravy changed the title Add HTTP request function Add send HTTP request for Deno Oct 3, 2022
@eigengravy eigengravy marked this pull request as draft October 5, 2022 05:17
@eigengravy eigengravy changed the title Add send HTTP request for Deno sendHTTPRequest Function using Deno Oct 7, 2022
@eigengravy eigengravy marked this pull request as ready for review October 7, 2022 08:42
@Meldiron
Copy link
Contributor

Meldiron commented Oct 7, 2022

@eigengravy , thanks for the PR! 🤯 Please give us some time to review it.

@Meldiron
Copy link
Contributor

Thanks for the amazing PR 😇 I have added small changes to fix empty body requests.
Merging the PR now 🥳

@Meldiron Meldiron merged commit 71971c2 into open-runtimes:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christyjacob4 christyjacob4 christyjacob4 left review comments

@Meldiron Meldiron Meldiron approved these changes

@PineappleIOnic PineappleIOnic PineappleIOnic approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

⚡ Write a sendHTTPRequest() Function using Deno
4 participants
@eigengravy @Meldiron @christyjacob4 @PineappleIOnic