Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4192 - Write a generateShortUrl() Function using Kotlin #136

Merged
merged 2 commits into from
Feb 23, 2023
Merged

4192 - Write a generateShortUrl() Function using Kotlin #136

merged 2 commits into from
Feb 23, 2023

Conversation

Ritzy-NCode
Copy link
Contributor

@Ritzy-NCode Ritzy-NCode commented Jan 31, 2023 •
edited
Loading

HI I dropped a message to assign it to me.
appwrite/appwrite#4192
Though i did not get a response I still went ahead and raised the PR.

appwrite/appwrite#4192

Feel free to close/reject if I dropped a ball here.

@Ritzy-NCode
Copy link
Contributor Author

Ritzy-NCode commented Jan 31, 2023 •
edited
Loading

bitly_success_response

invalid_provider_validation

provider missing validation

tinyurl_success_response

url_missing_validation

Meldiron
Meldiron approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some changes regarding variables. Looks good to me 🥳

@Meldiron Meldiron merged commit 988909f into open-runtimes:main Feb 23, 2023
@Meldiron
Copy link
Contributor

THANK YOU! All changes merged 🥳

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.

You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.

You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.

Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :)

@Ritzy-NCode Ritzy-NCode deleted the 4192 branch February 23, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meldiron Meldiron Meldiron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ritzy-NCode @Meldiron