Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Refactor benchmark script and update files #637

Merged
merged 3 commits into from
Dec 30, 2022

Conversation

fangyixiao18
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@fangyixiao18 fangyixiao18 added WIP Working in progress dev-1.x labels Dec 19, 2022
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 81.61% // Head: 81.65% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (dcae7cb) compared to base (fbe0ff6).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head dcae7cb differs from pull request most recent head 63cd230. Consider uploading reports for the commit 63cd230 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x     #637      +/-   ##
===========================================
+ Coverage    81.61%   81.65%   +0.04%     
===========================================
  Files          135      135              
  Lines         4961     4961              
  Branches       672      672              
===========================================
+ Hits          4049     4051       +2     
+ Misses         774      773       -1     
+ Partials       138      137       -1     
Flag Coverage Δ
unittests 81.65% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmselfsup/datasets/samplers/deepcluster_sampler.py 95.83% <100.00%> (ø)
mmselfsup/datasets/transforms/processing.py 89.22% <100.00%> (+0.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fangyixiao18 fangyixiao18 removed the WIP Working in progress label Dec 26, 2022
Copy link
Collaborator

@tonysy tonysy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fangyixiao18 fangyixiao18 merged commit 1fd3509 into open-mmlab:dev-1.x Dec 30, 2022
@fangyixiao18 fangyixiao18 deleted the benchmark-script branch January 10, 2023 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants