Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support input gt seg map is not 2D #2739

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

MeowZheng
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

fix #2593

Modification

  1. Only when gt seg map is 2D, extend its shape to 3D PixelData
  2. If seg map is not 2D, we raised warning for users.

@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.10 ⚠️

Comparison is base (a8aafdd) 83.45% compared to head (893e115) 83.36%.

❗ Current head 893e115 differs from pull request most recent head ec6db76. Consider uploading reports for the commit ec6db76 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2739      +/-   ##
===========================================
- Coverage    83.45%   83.36%   -0.10%     
===========================================
  Files          147      147              
  Lines         8669     8674       +5     
  Branches      1303     1304       +1     
===========================================
- Hits          7235     7231       -4     
- Misses        1204     1215      +11     
+ Partials       230      228       -2     
Flag Coverage Δ
unittests 83.36% <66.66%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/transforms/formatting.py 86.36% <66.66%> (-3.38%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MeowZheng MeowZheng requested a review from xiexinch March 13, 2023 03:47
@MeowZheng MeowZheng merged commit 6ba4696 into open-mmlab:dev-1.x Mar 14, 2023
@MeowZheng MeowZheng deleted the fix-format-data branch March 14, 2023 15:14
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
Thanks for your contribution and we appreciate it a lot. The following
instructions would make your pull request more healthy and more easily
get feedback. If you do not understand some items, don't worry, just
make the pull request and seek help from maintainers.

## Motivation

fix open-mmlab#2593

## Modification

1. Only when gt seg map is 2D, extend its shape to 3D PixelData 
2. If seg map is not 2D, we raised warning for users.

---------

Co-authored-by: xiexinch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants