Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Features]Support dump segment predition #2712

Merged
merged 12 commits into from
Mar 17, 2023

Conversation

MeowZheng
Copy link
Collaborator

@MeowZheng MeowZheng commented Mar 6, 2023

Motivation

  1. It is used to save the segmentation predictions as files and upload these files to a test server

Modification

  1. Add output_file and format only in IoUMetric

BC-breaking (Optional)

No

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@MeowZheng MeowZheng changed the title [WIP]Support dump segment predition [Features]Support dump segment predition Mar 7, 2023
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.09 ⚠️

Comparison is base (ff8d971) 83.72% compared to head (2a27073) 83.63%.

❗ Current head 2a27073 differs from pull request most recent head 43639cb. Consider uploading reports for the commit 43639cb to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2712      +/-   ##
===========================================
- Coverage    83.72%   83.63%   -0.09%     
===========================================
  Files          156      156              
  Lines         9333     9355      +22     
  Branches      1367     1373       +6     
===========================================
+ Hits          7814     7824      +10     
- Misses        1276     1289      +13     
+ Partials       243      242       -1     
Flag Coverage Δ
unittests 83.63% <80.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/transforms/formatting.py 97.72% <ø> (ø)
mmseg/evaluation/metrics/iou_metric.py 76.99% <77.27%> (-0.43%) ⬇️
mmseg/evaluation/metrics/citys_metric.py 87.01% <100.00%> (+0.34%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

mmseg/evaluation/metrics/iou_metric.py Outdated Show resolved Hide resolved
mmseg/evaluation/metrics/iou_metric.py Outdated Show resolved Hide resolved
docs/en/user_guides/4_train_test.md Outdated Show resolved Hide resolved
docs/en/user_guides/4_train_test.md Outdated Show resolved Hide resolved
@AI-Tianlong
Copy link
Contributor

Excellent work!!!! I really need this feature, hope to merge soon😍

docs/en/user_guides/4_train_test.md Outdated Show resolved Hide resolved
docs/zh_cn/user_guides/4_train_test.md Outdated Show resolved Hide resolved
@MeowZheng MeowZheng merged commit ff95416 into open-mmlab:dev-1.x Mar 17, 2023
@MeowZheng MeowZheng deleted the format-result branch March 17, 2023 14:58
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
## Motivation

1. It is used to save the segmentation predictions as files and upload
these files to a test server

## Modification

1. Add output_file and format only in `IoUMetric`
 
## BC-breaking (Optional)

No

## Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases
here, and update the documentation.

## Checklist

1. Pre-commit or other linting tools are used to fix the potential lint
issues.
3. The modification is covered by complete unit tests. If not, please
add more unit test to ensure the correctness.
4. If the modification has potential influence on downstream projects,
this PR should be tested with downstream projects, like MMDet or
MMDet3D.
5. The documentation has been modified accordingly, like docstring or
example tutorials.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants