Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Remove mmdet and mmcls from mminstall #2642

Merged
merged 5 commits into from
Feb 24, 2023

Conversation

MeowZheng
Copy link
Collaborator

@MeowZheng MeowZheng commented Feb 23, 2023

Motivation

As the mmdet and mmcls are not very stabel, and mim can install repo from source code, we remove them from mminstall and they won't be installed automatically when run mim install mmsegmentation

Modification

  1. remove mmdet and mcls from mminstall
  2. add explanation in faq

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 83.44% // Head: 83.52% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (aa756eb) compared to base (53fe1cc).
Patch has no changes to coverable lines.

❗ Current head aa756eb differs from pull request most recent head d56fdb2. Consider uploading reports for the commit d56fdb2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2642      +/-   ##
===========================================
+ Coverage    83.44%   83.52%   +0.08%     
===========================================
  Files          147      147              
  Lines         8620     8620              
  Branches      1293     1293              
===========================================
+ Hits          7193     7200       +7     
+ Misses        1205     1195      -10     
- Partials       222      225       +3     
Flag Coverage Δ
unittests 83.52% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/transforms/transforms.py 90.40% <0.00%> (+0.90%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

docs/en/notes/faq.md Outdated Show resolved Hide resolved
Co-authored-by: MengzhangLI <[email protected]>
@MeowZheng MeowZheng merged commit 619a3c2 into open-mmlab:dev-1.x Feb 24, 2023
@MeowZheng MeowZheng deleted the cls-det-remove branch February 24, 2023 06:58
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
## Motivation

As the mmdet and mmcls are not very stabel, and mim can install repo
from source code, we remove them from mminstall and they won't be
installed automatically when run `mim install mmsegmentation`

## Modification

1. remove mmdet and mcls from mminstall
2. add explanation in faq

---------

Co-authored-by: MengzhangLI <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants