Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Refine projects #2586

Merged
merged 9 commits into from
Feb 22, 2023
Merged

[Enhancement] Refine projects #2586

merged 9 commits into from
Feb 22, 2023

Conversation

MeowZheng
Copy link
Collaborator

@MeowZheng MeowZheng commented Feb 12, 2023 •
edited
Loading

Motivation

Make projects contribution more clear

Modification

  1. Add description on project/README
  2. Modify comments as reference in example_project/README
  3. Add faq for projects

BC-breaking (Optional)

No

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

xiexinch
xiexinch reviewed Feb 22, 2023
View reviewed changes
README_zh-CN.md Outdated Show resolved Hide resolved
projects/example_project/README.md Outdated Show resolved Hide resolved
projects/example_project/README.md Outdated Show resolved Hide resolved
projects/faq.md Outdated Show resolved Hide resolved
@MeowZheng MeowZheng merged commit 2d38bc8 into open-mmlab:dev-1.x Feb 22, 2023
@MeowZheng MeowZheng deleted the project-refine branch February 22, 2023 11:18
@gaotongxiao gaotongxiao mentioned this pull request Mar 8, 2023
Merged
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
@andrehuang @patrickvonplaten @williamberman
fix the in-place modification in unet condition when using controlnet (…
e2d9a9b 
…open-mmlab#2586)

* fix the in-place modification in unet condition when using controlnet, which will cause backprop errors when training

* add clone to mid block

* fix-copies

---------

Co-authored-by: Patrick von Platen <[email protected]>
Co-authored-by: William Berman <[email protected]>
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
@MeowZheng
[Enhancement] Refine projects (open-mmlab#2586)
5750e4d 
## Motivation

Make projects contribution more clear

## Modification

1. Add description on project/README
2. Modify comments to reference in example_project/README 
3. Add faq for projects

## BC-breaking (Optional)

No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiexinch xiexinch xiexinch approved these changes

Assignees

@xiexinch xiexinch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MeowZheng @xiexinch