Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Make scipy as a default dependency in runtime in dev-1.x #2362

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

MengzhangLI
Copy link
Contributor

Related PR: open-mmlab/mmdetection#9187

This PR is created to fix unit test error if scipy is installed, the AttributeError would not be raised in BEiT and MAE.

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 83.63% // Head: 83.17% // Decreases project coverage by -0.45% ⚠️

Coverage data is based on head (9451081) compared to base (d62774c).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 9451081 differs from pull request most recent head 9251100. Consider uploading reports for the commit 9251100 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2362      +/-   ##
===========================================
- Coverage    83.63%   83.17%   -0.46%     
===========================================
  Files          141      141              
  Lines         7974     7971       -3     
  Branches      1193     1193              
===========================================
- Hits          6669     6630      -39     
- Misses        1116     1157      +41     
+ Partials       189      184       -5     
Flag Coverage Δ
unittests 83.17% <100.00%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/backbones/beit.py 78.21% <100.00%> (-14.87%) ⬇️
mmseg/models/backbones/timm_backbone.py 45.83% <0.00%> (+8.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MeowZheng MeowZheng merged commit 383826f into open-mmlab:dev-1.x Nov 30, 2022
MeowZheng pushed a commit to MeowZheng/mmsegmentation that referenced this pull request Dec 30, 2022
…pen-mmlab#2362)

* [Enhance] Make scipy as a default dependency in runtime 1.x

* [Enhance] Make scipy as a default dependency in runtime in dev-1.x
@MengzhangLI MengzhangLI deleted the scipy_1.x branch January 9, 2023 14:31
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
* finish

* Apply suggestions from code review

* fix indent and import error in test_stable_diffusion_depth

---------

Co-authored-by: William Berman <[email protected]>
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
[Enhance] Make scipy as a default dependency in runtime in dev-1.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants