Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confusion matrix tools analysis #93

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

akmalulkhairin
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

  1. Add analysis tool to generate confusion matrix adapted from https://github.com/open-mmlab/mmdetection

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022

Codecov Report

Merging #93 (d08f230) into dev (4e39a45) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #93      +/-   ##
==========================================
+ Coverage   28.67%   28.76%   +0.08%     
==========================================
  Files         102      102              
  Lines        6604     6571      -33     
  Branches      990      985       -5     
==========================================
- Hits         1894     1890       -4     
+ Misses       4646     4617      -29     
  Partials       64       64              
Flag Coverage Δ
unittests 28.74% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...oi_extractors/rotate_single_level_roi_extractor.py 23.80% <0.00%> (-0.79%) ⬇️
mmrotate/models/dense_heads/rotated_anchor_head.py 10.12% <0.00%> (-0.64%) ⬇️
mmrotate/datasets/dota.py 11.17% <0.00%> (ø)
mmrotate/apis/inference.py 0.00% <0.00%> (ø)
mmrotate/datasets/pipelines/loading.py 30.43% <0.00%> (ø)
...ate/models/dense_heads/kfiou_rotate_retina_head.py 30.00% <0.00%> (ø)
...e/models/dense_heads/rotated_retina_refine_head.py 25.00% <0.00%> (ø)
...els/dense_heads/kfiou_rotate_retina_refine_head.py 25.00% <0.00%> (ø)
mmrotate/models/dense_heads/rotated_retina_head.py 16.66% <0.00%> (+0.36%) ⬆️
mmrotate/models/detectors/s2anet.py 17.64% <0.00%> (+0.50%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c9a592...d08f230. Read the comment docs.

Copy link
Collaborator

@yangxue0827 yangxue0827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne ZwwWayne merged commit 077ae5d into open-mmlab:dev Mar 9, 2022
@akmalulkhairin akmalulkhairin deleted the tools_confusion_matrix branch March 10, 2022 00:43
@zytx121 zytx121 mentioned this pull request Mar 10, 2022
@zytx121 zytx121 added this to Done in New Features Mar 14, 2022
@OpenMMLab-Assistant003
Copy link

Hi @akmalulkhairin!First of all, we want to express our gratitude for your significant PR in the MMRotate project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG

If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤ @akmalulkhairin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants