Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEBUG] Temporary fix for issue "'RoIAlignRotated' object has no attribute 'out_size'" #40 #51

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

DangChuong-DC
Copy link
Contributor

Motivation

Debug for issue #40

Modification

Since RiRoIAlignRotated object does not have attribute output_size but out_size, and vice versa for other RoI in mmcv.
-> Check if object is RiRoIAlignRotated then get out_size attribute, if not get output_size

BC-breaking (Optional)

This change make code work without changing downstream repo (mmcv), however I think better to update downstream mmcv repo; specifically in https://github.com/open-mmlab/mmcv/blob/fd3a1a16ea1d0b3def8719816007a5d6fd6b432e/mmcv/ops/riroi_align_rotated.py#L121
=> self.out_size to self.output_size

Use cases (Optional)

If this PR is for debugging #40

Copy link
Collaborator

@yangxue0827 yangxue0827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zytx121
Copy link
Collaborator

zytx121 commented Mar 2, 2022

Hi @DangChuong-DC
We intend to adopt your temporary solution. At the same time, we will also PR to mmcv to fix the inconsistency of variable names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants