Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support LaPa Dataset #2281

Merged
merged 15 commits into from
Apr 23, 2023
Merged

[Feature] Support LaPa Dataset #2281

merged 15 commits into from
Apr 23, 2023

Conversation

Tau-J
Copy link
Collaborator

@Tau-J Tau-J commented Apr 22, 2023

Motivation

  • A 106-points Face landmark dataset
  • support dataset class
  • dataset description in docs
  • dataset converter script
  • unit test
  • tests/data

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 ⚠️

Comparison is base (260d05c) 82.31% compared to head (8daec3b) 82.29%.

❗ Current head 8daec3b differs from pull request most recent head 3d593ec. Consider uploading reports for the commit 3d593ec to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2281      +/-   ##
===========================================
- Coverage    82.31%   82.29%   -0.03%     
===========================================
  Files          230      231       +1     
  Lines        13552    13576      +24     
  Branches      2301     2306       +5     
===========================================
+ Hits         11155    11172      +17     
- Misses        1866     1872       +6     
- Partials       531      532       +1     
Flag Coverage Δ
unittests 82.29% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/datasets/datasets/face/__init__.py 100.00% <100.00%> (ø)
mmpose/datasets/datasets/face/lapa_dataset.py 100.00% <100.00%> (ø)
mmpose/datasets/transforms/converting.py 92.68% <100.00%> (+5.72%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tau-J Tau-J mentioned this pull request Apr 22, 2023
11 tasks
@Tau-J Tau-J requested a review from Ben-Louis April 22, 2023 13:50
@Tau-J Tau-J merged commit d7711cb into open-mmlab:dev-1.x Apr 23, 2023
@Tau-J Tau-J deleted the tau/lapa branch April 23, 2023 04:13
Tau-J added a commit to Tau-J/mmpose that referenced this pull request Apr 25, 2023
Tau-J added a commit to Tau-J/mmpose that referenced this pull request Apr 25, 2023
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants