Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update algorithm readmes with performance tables #1709

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

liqikai9
Copy link
Collaborator

@liqikai9 liqikai9 commented Oct 9, 2022

Motivation

Update topdown_heatmap and topdown_regression algorithm readmes with performance tables for animal / face / hand / wholebody configs.

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@liqikai9 liqikai9 requested a review from ly015 October 9, 2022 15:19

| Model | Input Size | AP | AR | Details and Download |
| :--------: | :--------: | :---: | :---: | :-------------------------------------------------------: |
| HRNet-w32 | 256x256 | 0.740 | 0.780 | [hrnet_animalpose.md](./animalpose/hrnet_animalpose.md) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HRNet32 performance is abnormally high and unaligned with master. Please double check it with @Ben-Louis

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just run the test for this setting with master and dev-1.x, respectively. The results match this table but are different from the record.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then let's keep it this way in this PR. Meanwhile, @liqikai9 please retain the hrnet32 and hrnet48 models to further verify the performance.

@ly015 ly015 merged commit 304f262 into open-mmlab:dev-1.x Oct 10, 2022
ly015 pushed a commit that referenced this pull request Oct 14, 2022
* update algorithm readme with performance tables

* resolve comments
ly015 pushed a commit that referenced this pull request Oct 14, 2022
* update algorithm readme with performance tables

* resolve comments
@liqikai9 liqikai9 deleted the refine-model-performance-table branch October 26, 2022 07:22
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* update algorithm readme with performance tables

* resolve comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants