Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Update results and ckpts #1681

Merged
merged 6 commits into from
Oct 9, 2022
Merged

Conversation

liqikai9
Copy link
Collaborator

@liqikai9 liqikai9 commented Sep 23, 2022

Motivation

Update verified HRNet + COCO models and their checkpoints and logs with 1.x.

Update HRNet + PoseTrack18 test results on detector bboxes.

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@ly015
Copy link
Member

ly015 commented Sep 30, 2022

@liqikai9 Please resolve the conflits.

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 77.74% // Head: 77.75% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5ed2388) compared to base (d507fb1).
Patch has no changes to coverable lines.

❗ Current head 5ed2388 differs from pull request most recent head 8012b58. Consider uploading reports for the commit 8012b58 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #1681   +/-   ##
========================================
  Coverage    77.74%   77.75%           
========================================
  Files          204      204           
  Lines        11715    11715           
  Branches      1955     1955           
========================================
+ Hits          9108     9109    +1     
+ Misses        2212     2209    -3     
- Partials       395      397    +2     
Flag Coverage Δ
unittests 77.75% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../datasets/datasets/base/base_coco_style_dataset.py 89.74% <ø> (ø)
mmpose/datasets/transforms/common_transforms.py 82.62% <0.00%> (+0.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ly015
Copy link
Member

ly015 commented Sep 30, 2022

Lint seems faild.

@ly015 ly015 merged commit 4693395 into open-mmlab:dev-1.x Oct 9, 2022
ly015 pushed a commit that referenced this pull request Oct 14, 2022
ly015 pushed a commit that referenced this pull request Oct 14, 2022
@liqikai9 liqikai9 deleted the update-ckpts branch October 26, 2022 07:22
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants