Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix keypoint indices #1191

Merged
merged 5 commits into from
Feb 14, 2022
Merged

Conversation

liqikai9
Copy link
Collaborator

Motivation

Modification

Fix the method to get keypoint indices.

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #1191 (62dac92) into master (ccd5d87) will not change coverage.
The diff coverage is n/a.

❗ Current head 62dac92 differs from pull request most recent head 7b55763. Consider uploading reports for the commit 7b55763 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1191   +/-   ##
=======================================
  Coverage   82.49%   82.49%           
=======================================
  Files         204      204           
  Lines       16144    16144           
  Branches     2886     2886           
=======================================
  Hits        13318    13318           
  Misses       2096     2096           
  Partials      730      730           
Flag Coverage Δ
unittests 82.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccd5d87...7b55763. Read the comment docs.

@ly015 ly015 self-requested a review February 14, 2022 14:01
@ly015 ly015 merged commit a2643bd into open-mmlab:master Feb 14, 2022
@liqikai9 liqikai9 deleted the fix_valentinemagic branch February 25, 2022 06:44
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* fix keypoint indices

* fix typo

* add frame shape setting in webcam_runner

* use normalized distance

* fix heart checking

Co-authored-by: ly015 <[email protected]>
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* fix keypoint indices

* fix typo

* add frame shape setting in webcam_runner

* use normalized distance

* fix heart checking

Co-authored-by: ly015 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants