Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix benchmark #9865

Merged
merged 1 commit into from
Mar 6, 2023
Merged

fix benchmark #9865

merged 1 commit into from
Mar 6, 2023

Conversation

ghlerrix
Copy link
Contributor

@ghlerrix ghlerrix commented Mar 3, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

FPS benchmark tool can't work.
Detailed error content:
image

Modification

Modifications were made to lines 163 and 215 of benchmark.py

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2023

CLA assistant check
All committers have signed the CLA.

hhaAndroid
hhaAndroid previously approved these changes Mar 6, 2023
@ZwwWayne ZwwWayne changed the base branch from 3.x to dev-3.x March 6, 2023 15:12
@ZwwWayne ZwwWayne dismissed hhaAndroid’s stale review March 6, 2023 15:12

The base branch was changed.

@ZwwWayne ZwwWayne merged commit 95fac56 into open-mmlab:dev-3.x Mar 6, 2023
@vansin
Copy link
Collaborator

vansin commented Mar 8, 2023

@ghlerrix
Congratulations on having your first PR merged in OpenMMLab! I am a technical operations staff member of OpenMMLab. My WeChat ID is van-sin,please add me . I would like to invite you to join the OpenMMLab contributors WeChat group.

@okt7760
Copy link

okt7760 commented Mar 20, 2023

There is a new problem with the modified benchmark

AttributeError: 'DistributedDataParallel' object has no attribute 'test_step'

yumion pushed a commit to yumion/mmdetection that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants