[Fix] Fix VOC metrics #9784
Merged
[Fix] Fix VOC metrics #9784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RangiLyu
reviewed
Feb 17, 2023
RangiLyu
reviewed
Feb 17, 2023
RangiLyu
reviewed
Feb 17, 2023
| def process(self, data_batch: dict, data_samples: Sequence[dict]) -> None: | ||
| """transfer tensors in predictions to CPU.""" | ||
| data_samples = _to_cpu(data_samples) | ||
| for data_sample in data_samples: | ||
| # remove gt | ||
| data_sample.pop('gt_instances', None) | ||
| data_sample.pop('ignored_instances', None) | ||
| if not self.keep_gt: |
There was a problem hiding this comment.
I'm wondering whether we should keep gt in the dumped results. Because it is duplicated with the dataset annotation and is not compressed.
We can modify the eval_metric.py to load the annotation during offline evaluation.
Co-authored-by: RangiLyu <[email protected]>
Co-authored-by: RangiLyu <[email protected]>
RangiLyu
approved these changes
Feb 17, 2023
yumion
pushed a commit
to yumion/mmdetection
that referenced
this pull request
Jan 31, 2024
Co-authored-by: RangiLyu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eval_modeineval_map, or it will usedareawhen calculating VOC2007, which is wrong.