Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment repeater visualizer register #9740

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Conversation

chg0901
Copy link
Contributor

@chg0901 chg0901 commented Feb 8, 2023

visualizer has been created in line 31 and 34, if you run this demo in one notebook, we need not build the visualizer again.

# Init visualizer
visualizer = VISUALIZERS.build(model.cfg.visualizer)
# The dataset_meta is loaded from the checkpoint and 
# then pass to the model in init_detector
visualizer.dataset_meta = model.dataset_meta

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

# visualizer has been created in line 31 and 34, if you run this demo in one notebook,
# you need not register the visualizer again.

# Init visualizer
visualizer = VISUALIZERS.build(model.cfg.visualizer)
# The dataset_meta is loaded from the checkpoint and
# then pass to the model in init_detector
visualizer.dataset_meta = model.dataset_meta
@CLAassistant
Copy link

CLAassistant commented Feb 8, 2023

CLA assistant check
All committers have signed the CLA.

@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Feb 8, 2023

Hi @chg0901

Thanks for your kind PR. It seems that CLA is not signed. Could you sign the CLA so that eventually we could merge this PR after review? You can check the contents and follow the instruction in the communication box shown as below
image

@ZwwWayne ZwwWayne added this to the 3.0.0rc6 milestone Feb 8, 2023
@ZwwWayne ZwwWayne merged commit e15bb47 into open-mmlab:dev-3.x Feb 10, 2023
chg0901 added a commit to chg0901/mmdetection that referenced this pull request Feb 10, 2023
visualizer has been created in line 31 and 34, if you run this demo in one notebook, we need not build the visualizer again.
Please refer this pull request [9740](open-mmlab#9740)

# Init visualizer
visualizer = VISUALIZERS.build(model.cfg.visualizer)
# The dataset_meta is loaded from the checkpoint and 
# then pass to the model in init_detector
visualizer.dataset_meta = model.dataset_meta
@chg0901 chg0901 deleted the patch-2 branch February 10, 2023 17:21
yumion pushed a commit to yumion/mmdetection that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants