Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add typehint for DarknetBottleneck #9591

Merged
merged 5 commits into from
Jan 10, 2023

Conversation

PeterH0323
Copy link
Contributor

Motivation

Add typehint for DarknetBottleneck

Modification

mmdetection/mmdet/models/layers/csp_layer.py

@ZwwWayne ZwwWayne requested a review from RangiLyu January 9, 2023 04:43
@ZwwWayne ZwwWayne added this to the 3.0.0rc6 milestone Jan 9, 2023
mmdet/models/layers/csp_layer.py Outdated Show resolved Hide resolved
mmdet/models/layers/csp_layer.py Outdated Show resolved Hide resolved
mmdet/models/layers/csp_layer.py Outdated Show resolved Hide resolved
mmdet/models/layers/csp_layer.py Show resolved Hide resolved
mmdet/models/layers/csp_layer.py Outdated Show resolved Hide resolved
mmdet/models/layers/csp_layer.py Outdated Show resolved Hide resolved
@PeterH0323 PeterH0323 requested review from BIGWangYuDong and removed request for RangiLyu January 9, 2023 05:58
mmdet/models/layers/csp_layer.py Show resolved Hide resolved
mmdet/models/layers/csp_layer.py Outdated Show resolved Hide resolved
mmdet/models/layers/csp_layer.py Outdated Show resolved Hide resolved
@BIGWangYuDong
Copy link
Collaborator

BIGWangYuDong commented Jan 9, 2023

LGTM, thanks for your contribution! Please change the PR tile to the CodeCamp format! Also, it is suggested to finish CodeCamp tasks in this single PR.

@PeterH0323
Copy link
Contributor Author

PeterH0323 commented Jan 9, 2023

Hi @BIGWangYuDong ,我不是 CodeCamp 中 mmdet typehint 的报名成员,我正在为 MMYOLO 提交新算法的开发过程中发现了这个问题,顺手修复提的这个 PR 😄

Copy link
Collaborator

@BIGWangYuDong BIGWangYuDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne ZwwWayne merged commit 6e9cfd4 into open-mmlab:dev-3.x Jan 10, 2023
yumion pushed a commit to yumion/mmdetection that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants