Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix mmdet flops error #9589

Merged
merged 10 commits into from
Jan 18, 2023
Merged

[Fix] Fix mmdet flops error #9589

merged 10 commits into from
Jan 18, 2023

Conversation

zwhus
Copy link
Collaborator

@zwhus zwhus commented Jan 7, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Now, mmdet don't support compute flops for all configs. I add some functions and modify many configs to fix mmdet flops error.

Modification

  1. I mainly modify some configs and some metafile
  2. I add forward function to compute flops in cascade_roi_head, scnet_roi_head, htc_roi_head
  3. I add a function parameter in most of dense heads

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Jan 7, 2023

CLA assistant check
All committers have signed the CLA.

@zwhus zwhus changed the title 【Fix】Fix mmdet flops error [Fix] Fix mmdet flops error Jan 7, 2023
@ZwwWayne ZwwWayne added this to the 3.0.0rc6 milestone Jan 9, 2023
@hhaAndroid
Copy link
Collaborator

@zwhus I have no doubts about the code modification of this pr. The core question is how to calculate flops in two-stage is the most reasonable? I'm not very sure.

@ZwwWayne
Copy link
Collaborator

@zwhus I have no doubts about the code modification of this pr. The core question is how to calculate flops in two-stage is the most reasonable? I'm not very sure.

We can do it in the later PR. In this PR, we mainly fix the issue of metafile.

@ZwwWayne ZwwWayne merged commit d2a3cbb into open-mmlab:dev-3.x Jan 18, 2023
@zwhus zwhus deleted the dev-3.x branch March 9, 2023 13:40
@zwhus zwhus restored the dev-3.x branch March 9, 2023 13:40
@zwhus zwhus deleted the dev-3.x branch March 9, 2023 13:41
@jason102811
Copy link

Dear zwhus,
First of all, we want to express our gratitude for your significant PR in the MMDet project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
As a valued contributor, we would also like to invite you to join our Special Interest Group (SIG) private channel, where you can share your experiences, ideas, and build connections with like-minded peers.
Join us :https://discord.gg/raweFPmdzG
To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. We look forward to seeing you there!
Also,if you have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx,or scan the following QR code to join us. Please add "mmsig + Github ID" as a remark when adding friends:)
Best regards! @zwhus

yumion pushed a commit to yumion/mmdetection that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants