[Fix] Fix inconsistent float precision between mmdet and mmcv #9570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RangiLyu
reviewed
Jan 5, 2023
RangiLyu
approved these changes
Jan 6, 2023
Codecov ReportBase: 64.15% // Head: 64.12% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #9570 +/- ##
==========================================
- Coverage 64.15% 64.12% -0.03%
==========================================
Files 362 362
Lines 29604 29604
Branches 5036 5036
==========================================
- Hits 18991 18984 -7
- Misses 9604 9614 +10
+ Partials 1009 1006 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
3 tasks
thmegy
pushed a commit
to thmegy/mmdetection
that referenced
this pull request
May 5, 2023
…mlab#9570) * [Fix] Fix inconsistent float precision between mmdet and mmcv in coco.py * [Fix] Fix inconsistent float precision between mmdet and mmcv in lvis.py * Fix pytest in test_panoptic_dataset.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In coco.py and lvis.py, the float precision of bbox mAP of eval_result of evaluate() function is .3f,
However, in the float precision when printing log in mmcv is .4f,
see:
https://github.com/open-mmlab/mmcv/blob/ea173c9f07f0abf6873d2b7d786fb6411843cf00/mmcv/runner/hooks/logger/text.py#L178-L179
This PR suggests using the same .4f float precision. Another solution is not to limit the float precision in eval_result.
Fix #9569