Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeCamp #33 #9468

Merged
merged 4 commits into from
Dec 19, 2022
Merged

CodeCamp #33 #9468

merged 4 commits into from
Dec 19, 2022

Conversation

QJC123654
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Dec 9, 2022

CLA assistant check
All committers have signed the CLA.

@BIGWangYuDong
Copy link
Collaborator

Hi, Thanks for your PR; please remember to sign the CLA.
image

@BIGWangYuDong
Copy link
Collaborator

image
Unit Test is failed, please check and fix it

RangiLyu
RangiLyu previously approved these changes Dec 12, 2022
ZwwWayne
ZwwWayne previously approved these changes Dec 12, 2022
mmdet/models/task_modules/prior_generators/utils.py Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne added this to the 3.0.0rc6 milestone Dec 19, 2022
@QJC123654 QJC123654 dismissed stale reviews from ZwwWayne and RangiLyu via c176bc8 December 19, 2022 08:50
@ZwwWayne ZwwWayne merged commit 92e2eb3 into open-mmlab:dev-3.x Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants