Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeCamp #34 [Doc] update the zh_cn user_guides of useful_tools.md and useful_hooks.md #9453

Merged
merged 8 commits into from
Dec 12, 2022

Conversation

tianleiSHI
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

超级视客营-MMDetection-34

Modification

更新代码库中useful_tools.md and useful_hooks.md的中文部分

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Copy link
Collaborator

@zytx121 zytx121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zytx121 zytx121 mentioned this pull request Dec 7, 2022
@tianleiSHI tianleiSHI requested review from zytx121 and removed request for hhaAndroid and BIGWangYuDong December 7, 2022 02:29
@tianleiSHI
Copy link
Contributor Author

Sorry,point wrong @zytx121

zytx121
zytx121 previously approved these changes Dec 7, 2022
docs/zh_cn/user_guides/useful_hooks.md Outdated Show resolved Hide resolved
docs/zh_cn/user_guides/useful_tools.md Outdated Show resolved Hide resolved
docs/zh_cn/user_guides/useful_tools.md Outdated Show resolved Hide resolved
docs/zh_cn/user_guides/useful_tools.md Outdated Show resolved Hide resolved
@BIGWangYuDong
Copy link
Collaborator

@tianleiSHI Thanks for your PR. There are some comments that need to fix.

Copy link
Collaborator

@BIGWangYuDong BIGWangYuDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne ZwwWayne merged commit 3c83d05 into open-mmlab:dev-3.x Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants