Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Support modifying palette through configuration #9445

Merged
merged 10 commits into from
Jan 5, 2023

Conversation

hhaAndroid
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Resolved: #9309

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@hhaAndroid hhaAndroid changed the title fix order of palette [Enhance] Support modifying palette through configuration Dec 5, 2022
mmdet/apis/inference.py Outdated Show resolved Hide resolved
Copy link
Member

@RangiLyu RangiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UT failed

mmdet/apis/inference.py Outdated Show resolved Hide resolved
Copy link
Member

@RangiLyu RangiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to refactor CLASSES and PALETTE to lowercase

RangiLyu
RangiLyu previously approved these changes Dec 12, 2022
mmdet/apis/inference.py Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne added this to the 3.0.0rc6 milestone Dec 19, 2022
@ZwwWayne ZwwWayne merged commit daa85f3 into open-mmlab:dev-3.x Jan 5, 2023
yumion pushed a commit to yumion/mmdetection that referenced this pull request Jan 31, 2024
…#9445)

* fix order of palette

* fix order

* fix UT

* update

* fix comment

* fix UT

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants