Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeCamp #34 [Docs] Add Chinese version of single_stage_as_rpn.md and test_results_submission.md #9434

Merged
merged 29 commits into from
Jan 9, 2023

Conversation

137208
Copy link
Contributor

@137208 137208 commented Dec 3, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Dec 3, 2022

CLA assistant check
All committers have signed the CLA.

@ZwwWayne ZwwWayne added this to the 3.0.0rc5 milestone Dec 5, 2022
@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Dec 5, 2022

Hi @137208 ,
Thanks for your kind PR. Could you recover to use the original pre-commit-config? This is necessary to keep the consistency and make your code meets the lint requirements.

docs/zh_cn/user_guides/single_stage_as_rpn.md Outdated Show resolved Hide resolved
docs/zh_cn/user_guides/single_stage_as_rpn.md Outdated Show resolved Hide resolved
docs/zh_cn/user_guides/single_stage_as_rpn.md Outdated Show resolved Hide resolved
@BIGWangYuDong BIGWangYuDong changed the title Dev 3.x [Docs] Add Chinese version of single_stage_as_rpn.md and test_results_submission.md Dec 5, 2022
@BIGWangYuDong BIGWangYuDong changed the title [Docs] Add Chinese version of single_stage_as_rpn.md and test_results_submission.md CodeCamp #34 [Docs] Add Chinese version of single_stage_as_rpn.md and test_results_submission.md Dec 8, 2022
docs/zh_cn/user_guides/single_stage_as_rpn.md Outdated Show resolved Hide resolved
docs/zh_cn/user_guides/test_results_submission.md Outdated Show resolved Hide resolved
docs/zh_cn/user_guides/single_stage_as_rpn.md Outdated Show resolved Hide resolved
@RangiLyu
Copy link
Member

Hi, the lint failed. Please pip install pre-commit and run pre-commit run --all-files to fix it.

@ZwwWayne ZwwWayne merged commit 73e5960 into open-mmlab:dev-3.x Jan 9, 2023
yumion pushed a commit to yumion/mmdetection that referenced this pull request Jan 31, 2024
…_submission.md (open-mmlab#9434)

* Update single_stage_as_rpn.md

* Update single_stage_as_rpn.md

* Update single_stage_as_rpn.md

* Update single_stage_as_rpn.md

* Update single_stage_as_rpn.md

* Update test_results_submission.md

* Update single_stage_as_rpn.md

* Create test_results_submission.md

* Update test_results_submission.md

* Update single_stage_as_rpn.md

* Update single_stage_as_rpn.md

* Update test_results_submission.md

* update

* update

* update

* Update single_stage_as_rpn.md

* Update .pre-commit-config.yaml

* Update single_stage_as_rpn.md

* Update single_stage_as_rpn.md

* Update test_results_submission.md

* Update single_stage_as_rpn.md

* 已经运行pre-commit run --all-files,以下是其修改结果

* Update test_results_submission.md

* Update test_results_submission.md

* Update single_stage_as_rpn.md

* Update single_stage_as_rpn.md

* Update single_stage_as_rpn.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants