Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix Condinst predict error when val batch_size>1 #9400

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

liuyanyi
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

When set batch_size>1 in val_dataloader, got an error like this:

  File "/workspace/mmdetection/mmdet/models/detectors/single_stage_instance_seg.py", line 175, in predict
    results_list = self.mask_head.predict(
  File "/workspace/mmdetection/mmdet/models/dense_heads/base_mask_head.py", line 121, in predict
    results_list = self.predict_by_feat(
  File "/workspace/mmdetection/mmdet/models/dense_heads/condinst_head.py", line 1191, in predict_by_feat
    im_mask = self._predict_by_feat_single(
  File "/workspace/mmdetection/mmdet/models/dense_heads/condinst_head.py", line 1234, in _predict_by_feat_single
    mask_preds = aligned_bilinear(mask_preds, self.mask_out_stride)
  File "/workspace/mmdetection/mmdet/models/utils/misc.py", line 611, in aligned_bilinear
    assert tensor.dim() == 4
AssertionError

I found the loop in predict_by_feat overrides the mask_feats so the second batch will got the error because the dim is wrong.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@ZwwWayne ZwwWayne assigned RangiLyu and unassigned Czm369 Nov 28, 2022
@ZwwWayne ZwwWayne added this to the 3.0.0rc5 milestone Nov 28, 2022
@RangiLyu RangiLyu added bug Something isn't working v-3.x labels Nov 28, 2022
@ZwwWayne ZwwWayne merged commit 1ad5338 into open-mmlab:dev-3.x Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v-3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants