Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BC Breaking] Make sure the pipeline input shape is in WH order #9324

Merged
merged 12 commits into from
Dec 20, 2022

Conversation

hhaAndroid
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@RangiLyu RangiLyu added the v-3.x label Nov 15, 2022
@ZwwWayne ZwwWayne added this to the 3.0.0rc5 milestone Nov 21, 2022
@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Nov 21, 2022

Please also update some doc in the repo to indicate our conventions.

@hhaAndroid
Copy link
Collaborator Author

Please also update some doc in the repo to indicate our conventions.

I can't find any documentation for this information.

@BIGWangYuDong
Copy link
Collaborator

Should add some docs to tell users that the input setting is default as W, H, while the output should be H, W

@ZwwWayne ZwwWayne merged commit 7185b5a into open-mmlab:dev-3.x Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants