Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mmdet3.x InstanceSeg_Tutorial demo api #9226

Merged
merged 4 commits into from
Dec 2, 2022

Conversation

sanbuphy
Copy link
Contributor

@sanbuphy sanbuphy commented Nov 3, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@sanbuphy sanbuphy marked this pull request as draft November 3, 2022 13:37
@sanbuphy sanbuphy changed the title fix old demo api fix MMDet_InstanceSeg_Tutorial demo api Nov 3, 2022
@sanbuphy sanbuphy changed the title fix MMDet_InstanceSeg_Tutorial demo api fix InstanceSeg_Tutorial demo api Nov 3, 2022
@sanbuphy sanbuphy marked this pull request as ready for review November 4, 2022 02:02
@sanbuphy sanbuphy changed the title fix InstanceSeg_Tutorial demo api fix mmdet3.x InstanceSeg_Tutorial demo api Nov 4, 2022
@RangiLyu RangiLyu added the v-3.x label Nov 4, 2022
@ZwwWayne ZwwWayne added this to the 3.0.0rc5 milestone Nov 21, 2022
@ZwwWayne
Copy link
Collaborator

Hi @sanbuphy ,
Thanks for your kind PR.
For now, the tutorial seems to be a little big. Is there any way to reduce its size?

@sanbuphy
Copy link
Contributor Author

Hi @sanbuphy , Thanks for your kind PR. For now, the tutorial seems to be a little big. Is there any way to reduce its size?

Hi, I tried to reduce the size to 12.4MB , it less then MMDet_Tutorial.ipynb .

Copy link
Member

@RangiLyu RangiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Set draw_gt = False, here to avoid visualizing the original image.

@sanbuphy
Copy link
Contributor Author

image Set draw_gt = False, here to avoid visualizing the original image.

OK, I have fixed it.

@ZwwWayne ZwwWayne merged commit 7995952 into open-mmlab:dev-3.x Dec 2, 2022
@sanbuphy sanbuphy deleted the newdemo branch December 2, 2022 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants