[Fix] Enable to set float mlp_ratio in SwinTransformer #8670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the original implementation, the
mlp_ratio
parameter in theSwinTransformer
can be float, but the current mmdet's implementation does not support non-integermlp_ratio
(an Exception will be raised if a non-integer value is given).I have found the same fix in mmsegmentation:
see, open-mmlab/mmsegmentation#1274
Modification
When a float
mlp_ratio
is given, dims of mlp's out channels are truncated to an integer.BC-breaking (Optional)
I think this does not break BC.
Checklist