Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix training with single class dataset #4973

Merged
merged 3 commits into from
Apr 26, 2021
Merged

fix training with single class dataset #4973

merged 3 commits into from
Apr 26, 2021

Conversation

fcakyon
Copy link
Contributor

@fcakyon fcakyon commented Apr 15, 2021

fixes #4971

@fcakyon fcakyon changed the title fix num_classes check fix training with single class dataset Apr 15, 2021
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #4973 (fb74386) into master (bca2766) will increase coverage by 1.14%.
The diff coverage is 45.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4973      +/-   ##
==========================================
+ Coverage   65.59%   66.73%   +1.14%     
==========================================
  Files         255      259       +4     
  Lines       20036    20270     +234     
  Branches     3407     3447      +40     
==========================================
+ Hits        13142    13527     +385     
+ Misses       6188     6017     -171     
- Partials      706      726      +20     
Flag Coverage Δ
unittests 66.69% <45.00%> (+1.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/apis/inference.py 38.18% <4.76%> (-5.12%) ⬇️
mmdet/datasets/lvis.py 14.86% <10.00%> (+0.86%) ⬆️
mmdet/datasets/api_wrappers/coco_api.py 83.33% <83.33%> (ø)
mmdet/datasets/api_wrappers/__init__.py 100.00% <100.00%> (ø)
mmdet/datasets/coco.py 46.25% <100.00%> (-0.06%) ⬇️
mmdet/datasets/utils.py 100.00% <100.00%> (ø)
mmdet/models/roi_heads/base_roi_head.py 85.71% <100.00%> (ø)
mmdet/models/detectors/cornernet.py 94.87% <0.00%> (-5.13%) ⬇️
mmdet/models/dense_heads/corner_head.py 73.72% <0.00%> (-1.88%) ⬇️
mmdet/models/detectors/__init__.py 100.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a616886...fb74386. Read the comment docs.

mmdet/datasets/utils.py Outdated Show resolved Hide resolved
@fcakyon fcakyon requested a review from ZwwWayne April 16, 2021 07:21
mmdet/datasets/utils.py Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne self-assigned this Apr 19, 2021
@fcakyon fcakyon requested a review from ZwwWayne April 23, 2021 10:00
@ZwwWayne ZwwWayne merged commit 808472f into open-mmlab:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mmdet cannot train with single class dataset
2 participants