Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug: PAFPN has no attribute extra_convs_on_inputs #4235

Merged
merged 4 commits into from
Dec 8, 2020

Conversation

luuuyi
Copy link
Contributor

@luuuyi luuuyi commented Dec 6, 2020

PAFPN has no attribute extra_convs_on_inputs

retinanet-like detectors can use PAFPN

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Dec 6, 2020

Codecov Report

Merging #4235 (8fc55fe) into master (3e902c3) will decrease coverage by 0.01%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4235      +/-   ##
==========================================
- Coverage   62.66%   62.65%   -0.02%     
==========================================
  Files         232      232              
  Lines       17597    17601       +4     
  Branches     2942     2944       +2     
==========================================
  Hits        11028    11028              
- Misses       6031     6035       +4     
  Partials      538      538              
Flag Coverage Δ
unittests 62.61% <16.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/models/necks/pafpn.py 39.58% <0.00%> (-3.60%) ⬇️
mmdet/models/losses/cross_entropy_loss.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e902c3...29d120f. Read the comment docs.

@hellock
Copy link
Member

hellock commented Dec 6, 2020

Could you fix the linting error?

@luuuyi
Copy link
Contributor Author

luuuyi commented Dec 6, 2020

Could you fix the linting error?

sorry, the first lint error is some code line is too long. Ifix it, but the second lint error is yapf: files were modified by this hook. I have no idea how to fix it. Could you help me?

@hellock
Copy link
Member

hellock commented Dec 7, 2020

It can be merged since the linting error has been fixed. You can just ignore the errors appearing in build_parrots.

@hellock hellock merged commit 65b5de6 into open-mmlab:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants