Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-1069] - Fix dbt issues in ingestion #17247

Merged
merged 7 commits into from
Aug 2, 2024
Merged

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Jul 31, 2024

Describe your changes:

  • Fix test case creation by limiting it only if it does not already exists
  • Increase name VARCHAR length

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Bug fix

  • I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.

Copy link

@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Jul 31, 2024
pmbrull
pmbrull previously approved these changes Jul 31, 2024
Copy link
Contributor

Phylum OSS Supply Chain Risk Analysis - SUCCESS

The Phylum risk analysis is complete and has passed the active policy.

View this project in the Phylum UI

OnkarVO7
OnkarVO7 previously approved these changes Jul 31, 2024
pmbrull
pmbrull previously approved these changes Jul 31, 2024
OnkarVO7
OnkarVO7 previously approved these changes Aug 1, 2024
Copy link

sonarcloud bot commented Aug 2, 2024

Quality Gate Failed Quality Gate failed for 'open-metadata-ingestion'

Failed conditions
12.5% Coverage on New Code (required ≥ 20%)

See analysis details on SonarCloud

@TeddyCr TeddyCr merged commit 1349f16 into open-metadata:main Aug 2, 2024
16 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants