Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home: add get myPlanet banner (fixes #7476) #7477

Merged
merged 10 commits into from
Jun 6, 2024
Merged

home: add get myPlanet banner (fixes #7476) #7477

merged 10 commits into from
Jun 6, 2024

Conversation

Mutugiii
Copy link
Member

@Mutugiii Mutugiii commented Jun 5, 2024

Fixes #7476

  • Add a check for android devices
  • Add a banner for android devices linking to myPlanet

image

@Mutugiii Mutugiii requested a review from dogi June 5, 2024 14:55
@Mutugiii Mutugiii linked an issue Jun 5, 2024 that may be closed by this pull request
add android banner #7476
Closed
@dogi
Copy link
Member

dogi commented Jun 5, 2024

@Mutugiii instead of png here https://upload.wikimedia.org/wikipedia/commons/7/78/Google_Play_Store_badge_EN.svg

@dogi dogi changed the title home: add myPlanet android banner(fixes #7476) home: add myPlanet android banner (fixes #7476) Jun 5, 2024
@Mutugiii
Copy link
Member Author

Mutugiii commented Jun 6, 2024

Updated the svg

Tested on mobile and tablet -> detection is good
Tested on chromebook -> Android detection not working for chromebooks currently

4
4

@dogi dogi changed the title home: add myPlanet android banner (fixes #7476) home: add get myPlanet banner (fixes #7476) Jun 6, 2024
@dogi dogi merged commit 5bd5cd4 into master Jun 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dogi dogi dogi approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add android banner
2 participants
@Mutugiii @dogi