use deepEqual to check if All couses are selected. Issue #6799 #6841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbert
requested changes
Jul 16, 2020
| @@ -65,7 +70,6 @@ export class CertificationsAddComponent implements OnInit, AfterViewChecked { | |||
| this.cdRef.detectChanges(); | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Please put this line back in and be careful to not remove lines.
| @@ -49,6 +51,9 @@ export class CertificationsAddComponent implements OnInit, AfterViewChecked { | |||
| this.certificateForm.patchValue(certification); | |||
| this.certificateInfo._rev = certification._rev; | |||
| this.courseIds = certification.courseIds || []; | |||
| // here find out all courses in the system. compare all courses ids with this.coursesIds | |||
There was a problem hiding this comment.
CoursesComponent already fetches all of the course system so all courses are available in this.coursesTable.dataTable.data
| @@ -49,6 +51,9 @@ export class CertificationsAddComponent implements OnInit, AfterViewChecked { | |||
| this.certificateForm.patchValue(certification); | |||
| this.certificateInfo._rev = certification._rev; | |||
| this.courseIds = certification.courseIds || []; | |||
| // here find out all courses in the system. compare all courses ids with this.coursesIds | |||
| const allCourseIds = []; // find out hhow to get values for this array. | |||
| this.enableAddCourses = deepEqual(allCourseIds, this.courseIds ); | |||
There was a problem hiding this comment.
There is an extra space before the last parenthesis that should be removed.
There was a problem hiding this comment.
I am having a problem with my code, where the value of "hasAllData" variable is always "undefined" and the "if" statement does not get executed(line 62-65).
After debugging I noticed that
- this.courseTable does not have a dataTable.data property ( used this.courseTable.courses.data, instead)
- The first time you click on a course and click the edit button, the this.courseTable.courses.data is undefined. If you return back to certificate list and click on the same course again, this.courseTable.courses.data has 23 entries.
- The this.courseTable.courses.data must be local database data, feel like there should be more than 23 entries.
not sure how to go forward, what to try next to fix this issue. Any help would be appreciated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #6799
need to find out how to compare all of the courses from the database. how they are stored.