Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar: Add the space between buttons(fixes 6796) #6800

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

eonshikkim
Copy link
Contributor

@eonshikkim eonshikkim commented Jul 10, 2020

#6796

The only changed I had made was adding "margin-bottom: 15px;" after "position: relative;"
White spaces were removed automatically when I pushed or saved it. I don't know why.

Copy link
Member

@paulbert paulbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've changed the indentation in this file. Indentation should always be 2 spaces.

@@ -1,40 +1,38 @@
@import '~@fullcalendar/core/main.css';
@import '~@fullcalendar/daygrid/main.css';
@import '../app/variables';

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this line in the file.

}
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the newline at the end of the file.

Copy link
Member

@paulbert paulbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spykim2003 Please fix the indentation in the file. It should be 2 spaces, not 4.

@paulbert paulbert self-assigned this Jul 14, 2020
@paulbert
Copy link
Member

This messes up the alignment between the month and the buttons. Need a better solution than just adding a margin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants