6697 course team progress #6714
Conversation
| courses: { '$elemMatch': { '_id': course._id } } | ||
| }; | ||
| this.couchService.findAll('teams', findDocuments(selectors, 0)) | ||
| .pipe(tap(teams => this.courseTeams = teams)) |
There was a problem hiding this comment.
This tap is unnecessary. In fact both of the pipes here should just be performed in one subscribe.
| }; | ||
| this.couchService.findAll('teams', findDocuments(selectors, 0)) | ||
| .pipe(tap(teams => this.courseTeams = teams)) | ||
| .pipe(map(([ team ]) => { |
There was a problem hiding this comment.
When we initialize the component we should only get the list of the teams to populate the dropdown. When the selection changes we should check if we have the membership information and only then make the getTeamMembers request.
There's other problems with this block of code, also, but if you make the change above the below should be fixed, anyway.
I think you are trying to iterate over the array here, but the rxjs pipe map is different from Array.map. Since the http request returns an array of values, this map will just have the teams array returned to it and go through once.
This only runs getTeamMembers for the first team, so the members are only stored for that one team.
No description provided.