Survey: Append copy (fixes #5091)

[jsschf]

Fixes #5091

So the query works, however I'm having a strange issue where planet updates the amount of times a survey has been taken, but the submissions database doesn't reflect that.

This doesn't make sense to me because that data in SurveysComponent is coming from the submissions database. @paulbert @lmmrssa could you shed some light on what's happening here or tell me if I'm misunderstanding?

[paulbert]

I think the taken field is making it into the submissions document by mistake. That's a calculated field based on the number of documents in the submissions database for that test/survey, and it's not updated for all documents when the value changes.

Generally we try to make sure calculated fields like that do not make it into the database because it is misleading, but it looks like this one made it in. Sorry for the confusion!

[jsschf]

@paulbert Ok thanks that makes sense.

[jsschf]

@paulbert @lmmrssa I'm having trouble pushing my code because tslint is failing, and the debug log doesn't give specific information. Is there a way to find which line or which rule I'm breaking, or setting up an auto-format on save using the tslint.json rules?

[jsschf]

Hi @paulbert @lmmrssa two things:

• So yesterday I was working on this issue and it wasn't saving the updated name with - COPY appended. While I was trying to figure it out, I tried it again without changing anything and it worked. Today it doesn't work again and I'm not sure why.
• The copied surveys don't save the survey information, only the name and I'm not sure why either.
  

I would appreciate guidance on this issue.

[paulbert]

@jsschf When I tested I saw ** - COPY** added correctly after saving, but it was not added in the form. I also saw all of the question information was saved correctly.

I see that if you edit the name and then change it back to the previous one it will still save. You'll need to reset the validator to no exceptions (line 101 but without the parameter).

[paulbert]

Small thing, but there should be one more space in this indentation

[jsschf]

@paulbert Two of the Code Climate issues are that the constructor in ExamsAddComponent looks similar to the constructor in CoursesComponent, which I don't think necessitates a fix. The other two issues are that ngOnInit() exceeded both the Cognitive Complexity and lines of code allowances. I'm not sure how to refactor to resolve those issues. I would appreciate guidance.