Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#563] Update dashboard view (connects #563) #622

Merged
merged 11 commits into from
May 4, 2018

Conversation

paulbert
Copy link
Member

I can revert to the white/grey alternating for the lists, but since some of the designs have used small lines to divide instead tried that to see how it looks.

The left menu is just a placeholder for now, and on tablets it doesn't fit (it is also scrollable, however):

screenshot_2018-04-11-20-32-36

@lmmrssa
Copy link
Member

lmmrssa commented Apr 12, 2018

Function seems to be ok.

There has not been change on login page but the travis is failing on login test. It is looking for fields which exist on login form and being able to find it.

screen shot 2018-04-12 at 12 00 25

@paulbert
Copy link
Member Author

I didn't have time to look into this too deeply last night. I'm confused why the tests are failing on Travis without changing those pages. The tests pass locally, so this is difficult to debug.

@lmmrssa lmmrssa changed the title [#563] Update dashboard view [#563] Update dashboard view (connects #563) Apr 27, 2018
@paulbert paulbert force-pushed the 563-update-dashboard-view branch from 669b69d to a36e960 Compare May 3, 2018 00:19
@paulbert
Copy link
Member Author

paulbert commented May 3, 2018

Saving feedback: myLibrary, etc. should not be same size as "Planet Learning"

@paulbert paulbert force-pushed the 563-update-dashboard-view branch from 0b85044 to 4a1e5f7 Compare May 3, 2018 23:25
@paulbert
Copy link
Member Author

paulbert commented May 3, 2018

Looking at this more, the myLibrary, etc. and Planet Learning are both set to the normal Material header font size. We should increase the size of Planet Learning since it is our main header rather than have to change a bunch of headers in our other views. See #852

@lmmrssa
Copy link
Member

lmmrssa commented May 4, 2018

arrows has been replaced by scrollbar but arrow function are still not removed.

@lmmrssa
Copy link
Member

lmmrssa commented May 4, 2018

@paulbert I found most of codes from tile are not required so I have tried to remove them all please go through changes once and see any of those code has any need to be there? I have tested view and it looks nice.

@paulbert
Copy link
Member Author

paulbert commented May 4, 2018

Looks good, thanks!

@paulbert paulbert merged commit 3f4e4ef into master May 4, 2018
@lmmrssa lmmrssa deleted the 563-update-dashboard-view branch May 4, 2018 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants