re-ordering courses tool bar buttons fixes ( #4649 ) #4688
Conversation
ghost
mentioned this pull request
|
Changed the courses component to match the resources component. Fixing issue 4649. =>#4649 |
ghost
changed the title
There was a problem hiding this comment.
Note that there were different conditions for each button being shown. By simply moving around the elements the conditions are now off.
Again I would suggest you start with writing issues and PRs for open-learning-exchange.github.io before creating PRs on this project.
| @@ -37,18 +37,18 @@ | |||
| </button> | |||
| </ng-container> | |||
| <ng-container *ngIf="!parent"> | |||
| <mat-form-field class="font-size-1 margin-lr-3 mat-form-field-type-no-underline mat-form-field-dynamic-width"> | |||
There was a problem hiding this comment.
Please fix indentation for this block.
There was a problem hiding this comment.
@paulbert fixed indentation in the next commit.
I felt like the issues in that repository aren't as juicy as the ones in this one. |
|
@dogethecoder Thanks for fixing the indentation, but you did not address this part of the request:
|
|
@dogethecoder Please let me know if you need any more help or explanation on this PR. I'll be closing this on Monday if there is not an update before then. |
Hey just went through the button tag, could you highlight what attributes needed to be refactored?thanks, sorry for the late fix @paulbert |
|
@dogethecoder Please look through the template and make sure the conditions before your changes match the conditions after for the two buttons changed. |
Just went through the tags and i couldn't find any broken conditions. Also i didn't find any broken css. @paulbert |
|
@dogethecoder The conditions are not broken, but how they are applied to the buttons has changed. You need to make sure that the conditions that applied to each of the buttons before you made the changes are the same as the ones that apply to each of the buttons after the changes. |
|
@dogethecoder Do you need any more explanation with this PR? I'll be closing this on Friday if there are no updates. |
|
Closing since there are no recent updates. |
note this is the updated courses tool-bar, which is now symmetrical to the resource tool-bar. ^^^