used i18n for translation #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbert
requested changes
Sep 20, 2017
| @@ -1,4 +1,4 @@ | |||
| @import '../variables'; | |||
| @import '../variables.scss'; | |||
There was a problem hiding this comment.
Is this needed for the translation? I heard there was difficulty compiling the sass, so could you post the error you're seeing here & we can decide if that requires a separate issue.
There was a problem hiding this comment.
I got an error
$ ./node_modules/.bin/ng-xi18n
Error: Compilation failed. Resource file not found: D:/planet/src/app/variables
|
@dogi created https://crowdin.com/project/ole-planet/ - please join |
|
|
lmmrssa
force-pushed
the
i18n-multilingual
branch
from
46ea982
to
a4f86bd
Compare
paulbert
approved these changes
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ng serve --aot --i18n-file=src/i18n/messages.es.xlf --locale=es --i18n-format=xlf
@paul But I want to switch the language dynamically without using the above command for other other language.
I have followed the doc from https://medium.com/@feloy/deploying-an-i18n-angular-app-with-angular-cli-fc788f17e358 . I think it needs to deploy in production . I"ll also try it.