[#8] Unit test for meetup component #37
Conversation
lucy811
changed the title
src/app/meetups/meetups.component.ts
Outdated
| @@ -3,6 +3,7 @@ import { CouchService } from '../shared/couchdb.service'; | |||
|
|
|||
| @Component({ | |||
| templateUrl: './meetups.component.html', | |||
| providers:[CouchService] | |||
There was a problem hiding this comment.
This providers line should go into the configureTestingModule in the meetups.component.spec.ts file.
I had to read up to double check, but this actually instantiates a new CouchService class. While at this point it wouldn't break the app (the class isn't holding a shared state across components), for now we should stick with having a singleton service to connect to the DB.
| @@ -16,7 +16,8 @@ import { CouchService } from '../shared/couchdb.service'; | |||
| </div> | |||
| <button name="singlebutton" class="btn btn-primary" type="submit">Save</button> | |||
| </form> | |||
| ` | |||
| `, | |||
| providers:[CouchService] | |||
There was a problem hiding this comment.
Same comment as above, please move this into the meetupsadd.component.spec.ts file
There was a problem hiding this comment.
Looks good to me. You're creating a HTML test report. Next step is automatic testing and automatic reporting html https://github.com/ole-vi/planet/pull/24
|
@paulbert I have moved providers:[CouchService] to .spec.ts files. |
I used ng test to check the failure reasons.
Failed: Template parse errors: There is no directive with "exportAs" set to "ngForm" ("..
I added import { FormsModule } from '@angular/forms'; and imports: [ FormsModule] in meetupsadd.component.spec.ts
2)Error: No provider for CouchService!
I added @component({ providers:[CouchService] }) in meetups.component.ts and meetupsadd.component.ts
3)Error: No provider for Http
Expected undefined to be truth
I added import { HttpModule } from '@angular/http'; and imports: [ HttpModule ], in meetups.component.spec.ts and meetupsadd.component.spec.ts