[#352] dashboardview (connects #352) #362
Conversation
MacNew
commented
Jan 30, 2018
MacNew
commented
MacNew
requested review from
lmmrssa,
nirojdyola,
paulbert,
razu9861 and
BasnetSamriddhi
| <mat-grid-list cols="6" rowHeight="2:1"> | ||
| <mat-grid-tile class="backgroundcolor-purple"> | ||
| <mat-icon style="color:white;font:bold;" class="md-icon-36">event </mat-icon> | ||
|
|
There was a problem hiding this comment.
Could you please remove extra line?
| <mat-card> | ||
| <mat-card-content> | ||
| <mat-grid-list cols="6" rowHeight="2:1"> | ||
| <mat-grid-tile class="backgroundcolor-green"> |
There was a problem hiding this comment.
There are more spaces before . Please check it once .
| <mat-card-content> | ||
| <mat-grid-list cols="6" rowHeight="2:1"> | ||
| <mat-grid-tile class="backgroundcolor-orange"> | ||
| <mat-icon style="color:white;font:bold;" class="md-icon-36">library_books </mat-icon> |
There was a problem hiding this comment.
There are more spaces. Please check it once .
| </mat-card-content> | ||
| </mat-card> | ||
| </div> | ||
|
|
There was a problem hiding this comment.
Why there are two extra lines?
| @@ -0,0 +1,39 @@ | |||
| .dashboard-card-view { | |||
There was a problem hiding this comment.
Please follow indentation rule.
| <mat-divider></mat-divider> | ||
| <div class="dashboard-card-view-library"> | ||
| <mat-card> | ||
| <mat-card-content> |
There was a problem hiding this comment.
indentaion there are extra spaces
src/app/dashboard/dashboard.scss
Outdated
| .md-icon-36 { | ||
| @include md-icon-size(46px); | ||
| } | ||
|
|
| @@ -4,9 +4,8 @@ import { UserService } from '../shared/user.service'; | |||
|
|
|||
| // Main page once logged in. At this stage is more of a placeholder. | |||
| @Component({ | |||
| template: ` | |||
| <div id="greeting">Hi, {{name}}</div> | |||
There was a problem hiding this comment.
can we have greeting messages for now.
There was a problem hiding this comment.
its ok not to have greeting message
| <mat-card-content> | ||
| <mat-grid-list cols="6" rowHeight="2:1"> | ||
| <mat-grid-tile class="backgroundcolor-orange"> | ||
| <mat-icon style="color:white;font:bold;" class="md-icon-36">library_books </mat-icon> |
There was a problem hiding this comment.
styles should go in scss file, bootstrap class should not be used
| @@ -0,0 +1,74 @@ | |||
| <mat-card class="dashboard-card-view"> | |||
| <div class="dashboard-contain-image-and-string"> | |||
There was a problem hiding this comment.
can we have i18n translation tag added in all places
|
images used should be from the icon drive and also there is white space at bottom of all sections |
|
|
|
|
|
|
|
|
|
|
||
| export class DashboardComponent implements OnInit { | ||
| myLibrary = [ |
There was a problem hiding this comment.
pull data from database instead of having it written
| constructor( | ||
| private userService: UserService | ||
| ) {} | ||
|
|
||
| ngOnInit() { | ||
| Object.assign(this, this.userService.get()); | ||
| } | ||
|
|
||
| nextLibrary() { | ||
| this.myLibrary = this.myLibrary.concat( this.myLibrary.splice( 0, 4 ) ); |
There was a problem hiding this comment.
instead of playing around with array add pointer to point out the current position
|
@paulbert shall we make content scrollable or sort the data instead to avoid scrolling half of the content of a card |
|
closing icon on favor of https://github.com/ole-vi/planet/pull/393 |
