[#348] Message section added(connects #348) #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasnetSamriddhi
requested review from
lmmrssa,
razu9861,
nirojdyola and
paulbert
nirojdyola
reviewed
Jan 26, 2018
src/app/app.module.ts
Outdated
| import { CouchService } from './shared/couchdb.service'; | ||
| import { AuthService } from './shared/auth-guard.service'; | ||
| import { UserService } from './shared/user.service'; | ||
| import { ValidatorService } from './validators/validator.service'; | ||
|
|
||
| import { MatSnackBarModule } from '@angular/material/snack-bar'; |
There was a problem hiding this comment.
The material module should be define in material file . Could you please remove this and define it in Materail file.
nirojdyola
approved these changes
Jan 29, 2018
paulbert
approved these changes
Feb 5, 2018
There was a problem hiding this comment.
One small change, but otherwise this looks good to merge.
On a side note, we should be able to do translations from the .ts files as part of a future 5.x release: angular/angular#11405 (comment)
src/app/app.module.ts
Outdated
| @@ -6,12 +6,10 @@ import { AppComponent } from './app.component'; | |||
| import { PageNotFoundComponent } from './page-not-found/page-not-found.component'; | |||
|
|
|||
| import { AppRoutingModule } from './app-router.module'; | |||
|
|
|||
There was a problem hiding this comment.
Please leave these spaces in. We do not need these changes in the history.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.