(Fixes #2743) Submissions: Clarify Grading Status #3204
Conversation
|
I had to make multiple commits to fix the issues it was having with indentation. |
|
@YuserahN looks like you are making changes on github web portal. You should try to work on local copy of code. So you will be able to work on multiple files also you can test linting issue that way. |
|
@lmmrssa That is what I normally do. I use gitbash to work on a local copy of the code and then push it to the web portal. But I was running into tslint errors and was not sure how to view them using git commands. So I just created the PR using the web portal and was able to view and fix the issues that way. For future reference, how do I view the linting errors using git? |
|
@YuserahN you need to run https://github.com/open-learning-exchange/planet/blob/master/README.md this page gives you more detail on it some of lint command that you can run on planet. |
|
@lmmrssa Yes, I ran |
|
@lmmrssa Why does it still give me errors even when I am using 2 space indentation? Doesn't that just mean I am supposed to press the spacebar twice? |
|
@YuserahN there are different linting rules we have set not just two whitespace rule. So please check the linting fail. That will give detail about which line and and column there is error along with which error has occured. |
| @@ -36,6 +36,7 @@ | |||
| <mat-chip-list *ngIf="this.filter.type === 'survey' && element.status === 'complete'"><mat-chip selected il8n>complete</mat-chip></mat-chip-list> | |||
| <mat-chip-list *ngIf="element.status ==='graded'"><mat-chip selected i18n>graded</mat-chip></mat-chip-list> | |||
| <mat-chip-list *ngIf="element.status==='pending'"><mat-chip i18n>pending</mat-chip></mat-chip-list> | |||
| <mat-chip-list *ngIf="element.status==='requires grading'"><mat-chip selected color="accent" i18n>requires grading</mat-chip></mat-chip-list> | |||
There was a problem hiding this comment.
@YuserahN can we make status to be one word while saving.
There was a problem hiding this comment.
@singharpita You mean, 'requires grading' should be something like, 'Submitted'?
There was a problem hiding this comment.
may be require_grading not_graded or something but not separated by space
There was a problem hiding this comment.
@singharpita @YuserahN Let's leave it with a space, please.
Fixes #2743